Skip to content

feat(page): pass the keywords of go_to on to Ferrum - #367

Merged
route merged 1 commit into
mainfrom
feat/go-to-keywords
Nov 20, 2026
Merged

route merged 1 commit into
mainfrom
feat/go-to-keywords

Conversation

@route

@route route commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

Page#go_to took only the URL, so the keywords of Ferrum's go_to couldn't be used through Cuprite: referrer:, timeout: and on_timeout: raised ArgumentError.

  • go_to(url = nil, **options) passes them on to Ferrum, the pending connections check is unchanged.
  • Ferrum removed permanent: of headers.add in favor of go_to(url, referrer:), so docs/11-headers.md shows that instead.
  • The skipped with headers specs in spec/driver_spec.rb and their popup_headers view are removed. Unskipped, 4 of 5 failed: three set Host, which Chrome rejects in Network.setExtraHTTPHeaders (net::ERR_INVALID_ARGUMENT), and the rest expected headers to propagate to other windows or relied on the removed temporary/permanent split. Headers are per page in Ferrum and Cuprite adds nothing on top, so there was nothing of Cuprite's left to cover.

Needs Ferrum main at rubycdp/ferrum@5743cc8 or later for referrer:.

Page#go_to took only the URL, so Ferrum's referrer:, timeout: and on_timeout: couldn't be used through Cuprite.
Ferrum removed permanent: of headers.add in favor of go_to(url, referrer:), so the docs show that instead.
The skipped headers specs in driver_spec.rb are removed: they tested Ferrum's per-page headers, the removed
temporary/permanent split and propagation to other windows, and set Host, which Chrome rejects.
@route
route force-pushed the feat/go-to-keywords branch from 486227b to 234b884 Compare November 20, 2026 10:01
@route
route merged commit a2368e6 into main Nov 20, 2026
6 checks passed
@route
route deleted the feat/go-to-keywords branch November 20, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant